-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add complete metadata config example with xpaths #67
Conversation
@morch23mj How can I create a new line for the xpath values? |
That's possible through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update DE
and CS
documents too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kate-Lyndegaard I think this list is very valuable. I just wonder if it could be a bit too much input for someone reading the documentation. Did you consider providing the list for download somewhere or the like and only link it from the documentation or put it on a separate page of the documentation so that advanced users can read it and less advances users are not overwhelmed?
Do we also need to add it to the German version?
@morch23mj Yes, that would be good.
@JohannaOtt I simply updated the existing documentation. If we want to change it now to link to a document, that is fine with me. @morch23mj Where would I store such a document that I could then link to?
We can link the document on the German page, or is something else needed? |
Not sure if we also want to translate the descriptions and labels in the config. But IMO, users using the metadata config usually understand English, so I would tend to leave it as is. |
@Kate-Lyndegaard @JohannaOtt I just checked and there is also the possibility of having a collapsable section (example here). Is that maybe easier? If so, I can try to work on it. |
@morch23mj Oooh, I like the collapsable section. That would be great here. |
@morch23mj Can this be merged, or should it wait for additional changes? |
@Kate-Lyndegaard I think if it's not super urgent, first makes sense to add the changes related to the collapsible section. |
@morch23mj I tried to add the collapsible section, however I got the following: |
@Kate-Lyndegaard At least from the image, I see that |
@morch23mj I tried to follow the directions in the link you posted. It would be great if this is a quick fix. I just don't like leaving large and useful PRs hanging around. |
1ec2606
to
323a7fc
Compare
@Kate-Lyndegaard @JohannaOtt I've made the two sections collapsable, and documented how it'd done in the README.md file for future reference. There are two example sections (both collapsable), one is minimal (the one used before) and the other one is very detailed. I thought it's a good idea to keep both? If the short one isn't needed anymore then it can be deleted before merging. Added same for other locales: de/cs. |
@morch23mj Only looked at the screenshot now. Is there an easy way to change the design of them to adapt it to our documentation. Otherwise, LGTM |
@JohannaOtt Thanks for the feedback. :) I have inspected what styles are applied there, and it seems it's the ones coming from our theme. In this case, it's Yellow color is reserved for If you still see that we could improve something here, your input is welcome! |
@morch23mj Thank you, @morch23mj ! |
ING-3963