-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dataset series section is added #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do new pages also need to be added/linked from somewhere or the like so that it gets displayed at the right place of the documentation at all?
Or is that automatically happen once the file is available in the respective folder?
|
||
--- | ||
|
||
The Dataset series section displays a list of the sub-datasets contained within the published dataset series. Each sub-dataset listing provides an overview of the status of the resource. Direct links to the sub-dataset, it's data file, metadata, and view and download services are available. Visit [Dataset series](../../create-manage-datasets/create-dataset-series/2014-01-01-dataset-series.md) for more information about dataset series. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a short sentence that this section is only displayed in case the dataset is a dataset series/belongs to a series enabled theme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohannaOtt Could you please provide the DE translations of this sentence here? I would really like to minimize the back-and-forth on some of these PRs.
"The Dataset series section is displayed only for datasets that have dataset series enabled in the theme."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Der «Datensatz-Reihe»-Bereich wird nur für Datensätze angezeigt, die zu Themen gehören, für die Datensatz-Reihe aktiviert ist.
- "help-page-category-reference" | ||
- "help-page-subcategory-reference-data" | ||
layout: help-detail | ||
language: en |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
language: en -> language: de ?
|
||
--- | ||
|
||
Im «Datensatz-Reihe»-Bereich wird eine Liste der enthaltenen Datensätzen angezeigt, die in der veröffentlichten Datensatzreihe enthalten sind. Jeden Datensatz bietet einen Überblick über den Status der Ressource. Direkte Links zum enthaltenen Datensatz, seiner Datendatei, Metadaten sowie Darstellungs- und Download-Diensten sind verfügbar. Weitere Informationen finden sie unter [Datensatz-Reihe](../../create-manage-datasets/create-dataset-series/2014-01-01-dataset-series.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jeden Datensatz bietet einen Überblick --> Jeder Datensatz bietet einen Überblick
zum enthaltenen Datensatz, seiner Datendatei --> zum enthaltenen Datensatz, seiner Datei oder Dateien
@morch23mj How can we select where newly added files appear in the group of files in a section? |
@Kate-Lyndegaard At least from what I see now, there is this For instance:
That could be used for new files, or |
Thank you, @morch23mj |
@Kate-Lyndegaard since positions were changed in |
@morch23mj There are no sidebar_position attributes in the cz files. Also, I am not sure we are updating their documentation.. @stempler How do we handle updates to the documentation for NAKIT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -5,7 +5,7 @@ categories: | |||
- "help-page-subcategory-reference-data" | |||
layout: help-detail | |||
language: en | |||
sidebar_position: 10 | |||
sidebar_position: 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will not check in detail if these numbers make sense. We will see if they display as expected once the updated website is deployed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohannaOtt I'm running the website locally. It looks like this, any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohannaOtt I will add the Monitoring section in a new and separate PR. There I can also fix the "Access controls". The History section is not on production, because it is not functional so I will not add that for the time being.
@morch23mj Do you know why the build is failing? I can't see anything wrong with the document reference it's failing on. |
@Kate-Lyndegaard build reports:
Could you quickly check locally if the linked document (../../create-manage-datasets/create-dataset-series/2014-01-01-dataset-series.md) is accessible from the page (hc-documentation/docs/references/data/2018-03-07-reference-data-dataset-series.md)? No initial thoughts, I can't spot the error, since this is also done in other documents similarly. I can also run this locally later and try to fix it. As for NAKIT, I recall they gave us the translated documents and we just put them there, so might be we don't need to update those. |
@morch23mj The linking works as expected when running the documentation website locally... |
No description provided.