Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous PATH export #329

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Dec 19, 2023

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

This updates the documentation for using forgit as a subcommand of git by removing the use of the export built-in. For all intensive purposes, PATH is already exported. If it weren't, then executing a subprocess (ex. system("bash ...")) would always fail since PATH wouldn't be copied from parent to child. This simplifies the export line accordingly.

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

Copy link
Collaborator

@cjappl cjappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, I'll merge it sometime tomorrow unless someone else has an objection

@cjappl cjappl merged commit d7f88d7 into wfxr:master Dec 20, 2023
4 checks passed
@cjappl
Copy link
Collaborator

cjappl commented Dec 20, 2023

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants