automatically create nondigest non versioned files on asset precompile #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way non digest assets are created changed a little bit from always copying the whole to only copying changed files on each run. With this, the task can automatically be invoked on each precompile run and only copies something if needed. The only Rails config change to make this gem work now is to add a `Rails.application.config.assets.precompile += %w( webshims/* )` to an initializer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way non digest assets are created changed a little bit from always
copying the whole to only copying changed files on each run. With this,
the task can automatically be invoked on each precompile run and only
copies something if needed.
The only Rails config change to make this gem work now is to add a
Rails.application.config.assets.precompile += %w( webshims/* )to aninitializer.
IMO this simplifies installation and updating process a lot (even though only in the non versioned directoy case).
If this PR could be accepted, I can update the readme accordingly, too.
Credit: I basically pulled this out of https://github.com/galetahub/ckeditor/blob/cf7483fe9d202613e5702fc4ffe894c94d50a6ee/lib/tasks/ckeditor.rake.