Skip to content

Commit

Permalink
feat: change rules according to Symfony's PER-CS2.0 ruleset
Browse files Browse the repository at this point in the history
The PER-CS2.0 ruleset of Symfony doesn't match the documentation. We choose the more readable version, which is also part of the official PER-CS2.0 ruleset (https://cs.symfony.com/doc/ruleSets/PER-CS2.0.html)

#15
  • Loading branch information
marcwieland95 committed Dec 11, 2024
1 parent e778bb3 commit 4413f3c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ If you don't use PHPStan or similar for static type checking, that could be a pr
- Add `MultilinePromotedPropertiesFixer` (https://github.com/whatwedo/PhpCodingStandard/issues/27)
- Add `PhpdocToReturnTypeFixer` and `PhpdocToParamTypeFixer`
- `NoDoctrineMigrationsGeneratedCommentFixer` is now part of the default configuration (https://github.com/whatwedo/PhpCodingStandard/issues/16)
- `ConcatSpaceFixer` => `'spacing' => 'none'` is now part of the default configuration (https://github.com/whatwedo/PhpCodingStandard/issues/15)
- `ConcatSpaceFixer` => `'spacing' => 'one'` was added (https://github.com/whatwedo/PhpCodingStandard/issues/15)

### Removed
- Remove deprecated `NoTrailingCommaInListCallFixer`
- `ConcatSpaceFixer` => `'spacing' => 'none'` was replaced with `'spacing' => 'one'` for projects with the Symfony rule set in place
- `AssignmentInConditionSniff` is skipped

---
Expand Down
2 changes: 1 addition & 1 deletion config/whatwedo-common.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@

// https://github.com/whatwedo/PhpCodingStandard/issues/15
$ecsConfig->ruleWithConfiguration(ConcatSpaceFixer::class, [
'spacing' => 'none',
'spacing' => 'one',
]);

$ecsConfig->skip([
Expand Down

0 comments on commit 4413f3c

Please sign in to comment.