Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ConcatSpaceFixer #15

Open
rugbymauri opened this issue May 21, 2024 · 4 comments
Open

remove ConcatSpaceFixer #15

rugbymauri opened this issue May 21, 2024 · 4 comments
Milestone

Comments

@rugbymauri
Copy link
Contributor

remove ConcatSpaceFixer in whatwedo-symfony.php

$ecsConfig->ruleWithConfiguration(ConcatSpaceFixer::class, [
        'spacing' => 'none',
    ])
@tuxes3
Copy link
Member

tuxes3 commented May 23, 2024

symfony standards do not use spacing after . https://symfony.com/doc/current/contributing/code/standards.html#structure

@tuxes3 tuxes3 closed this as completed May 23, 2024
@marcwieland95
Copy link
Member

The PER-CS2.0 ruleset of Symfony doesn't match the documentation.

https://symfony.com/doc/current/contributing/code/standards.html#structure

Add a single space around binary operators (==, &&, ...), with the exception of the concatenation (.) operator;

https://cs.symfony.com/doc/ruleSets/PER-CS2.0.html

concat_space with config: ['spacing' => 'one']

I prefer a space around the dot, which makes things more readable.
What's your take @rugbymauri @tuxes3 @xarem

@marcwieland95 marcwieland95 reopened this Dec 10, 2024
@tuxes3
Copy link
Member

tuxes3 commented Dec 10, 2024

@marcwieland95 i did not know that both ways are documented. In that case we can use the more used PER-CS2.0 style. starting from whatwedo/PhpCodingStandard@^v2.0

marcwieland95 added a commit that referenced this issue Dec 11, 2024
The PER-CS2.0 ruleset of Symfony doesn't match the documentation. We choose the more readable version, which is also part of the official PER-CS2.0 ruleset (https://cs.symfony.com/doc/ruleSets/PER-CS2.0.html)

#15
marcwieland95 added a commit that referenced this issue Dec 11, 2024
The PER-CS2.0 ruleset of Symfony doesn't match the documentation. We choose the more readable version, which is also part of the official PER-CS2.0 ruleset (https://cs.symfony.com/doc/ruleSets/PER-CS2.0.html)

#15
@marcwieland95
Copy link
Member

I added it accordingly into the v2.0.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants