Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhanced Project Interaction with exec.sh to shell.sh Transition #66

Conversation

sbaerlocher
Copy link
Contributor

@sbaerlocher sbaerlocher commented Feb 22, 2024

Project Script Revisions and Additions: Alignment with Ticket #35

Revisions in commands/project/exec.sh

  • Updated the script by renaming the exec command to shell, in line with user feedback and suggestions captured in GitHub ticket #35. A notification (_logYellow) alerts users to this change, enhancing understandability and usage consistency.
  • Preserved essential functionality, including project status checks, service existence verification, and running status checks, with improvements for more efficient shell opening in the specified or default container.

Removal of commands/project/exec/root.sh

  • In alignment with the objectives outlined in ticket #35, this file was removed to streamline command structure and reduce redundancy, thereby simplifying the project's script architecture.

Addition of commands/project/shell.sh

  • Introduced the project:shell command (aliases p:s, shell), as suggested in ticket #35, for opening a shell with user dde in the first container. This script enhances the project's flexibility and user accessibility by incorporating checks for project initialization, service existence, and service operational status.

Addition of commands/project/shell/root.sh

  • A new script, project:shell:root (aliases p:s:r, shell-root), has been added to offer a privileged shell access option within the first container. This addition addresses needs highlighted in ticket #35 for more granular control and access within the project environment.
  • Ensures the project is operational with preliminary checks before opening a privileged shell, adhering to the usability improvements and simplifications proposed in the ticket.

@sbaerlocher sbaerlocher changed the title feat: move exec to shell feat: Enhanced Project Interaction with exec.sh to shell.sh Transition Feb 22, 2024
@sbaerlocher sbaerlocher force-pushed the feature/35-rename-projectexec-to-projectshell branch 2 times, most recently from 24d2e02 to e4ca477 Compare February 22, 2024 14:06
@sbaerlocher sbaerlocher force-pushed the feature/35-rename-projectexec-to-projectshell branch from e4ca477 to ac5ebb0 Compare February 22, 2024 14:09
commands/project/shell/root.sh Outdated Show resolved Hide resolved
commands/project/shell/root.sh Outdated Show resolved Hide resolved
@sbaerlocher sbaerlocher requested a review from s4mpl3d February 22, 2024 15:58
@sbaerlocher sbaerlocher force-pushed the feature/35-rename-projectexec-to-projectshell branch from 5b15f07 to 5129c48 Compare February 22, 2024 16:10
@sbaerlocher sbaerlocher force-pushed the feature/35-rename-projectexec-to-projectshell branch from 5129c48 to 48567e2 Compare February 22, 2024 16:10
commands/project/shell/root.sh Outdated Show resolved Hide resolved
commands/project/shell/root.sh Show resolved Hide resolved
commands/project/exec/root.sh Show resolved Hide resolved
@s4mpl3d s4mpl3d self-requested a review February 23, 2024 14:10
@sbaerlocher sbaerlocher merged commit 4682d0b into whatwedo:master Feb 23, 2024
1 check passed
@sbaerlocher sbaerlocher deleted the feature/35-rename-projectexec-to-projectshell branch February 23, 2024 14:11
@s4mpl3d
Copy link
Member

s4mpl3d commented Feb 24, 2024

@sbaerlocher, when using transformers for descriptions, please:

  • Aim for brevity; avoid lengthy text
    
  • Ensure accuracy by reviewing before posting
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants