Use the new wattsi-server URL #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was guessing/hoping that HTTPS would automatically negotiate compression at the TLS layer. I checked in Wireshark, at it turns out that both over plain HTTP and HTTPS, we send ~7MB and receive ~4MB, either this isn't a feature of the protocol, or one needs to do something to opt into it. http://security.stackexchange.com/questions/20406/is-http-compression-safe could be why it doesn't happen by default, if it ever did. Still, https://build.whatwg.org/ works, so I'll merge this with a tweaked commit message and we can look for other solutions to whatwg/build.whatwg.org#85 |
Unfortunately, using HTTPS doesn't automatically compress, see #64 (comment)
foolip
force-pushed
the
new-build-server
branch
from
d2a60e5
to
594dd34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes whatwg/build.whatwg.org#85. @foolip can you verify that this is actually using compression as expected? I didn't really understand how HTTPS gives automatic compression...