Allow doubles for ProgressEvent's loaded and total #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll double check, in principle it seems fine. @smaug----? |
domenic
added a commit
to webmachinelearning/writing-assistance-apis
that referenced
this pull request
Jan 22, 2025
Closes #15. Depends on whatwg/xhr#394.
This allows specifications to use ProgressEvents while not necessarily giving away the exact number of bytes, while maintaining a granularity greater than just 1 part in 100. See discussion in webmachinelearning/writing-assistance-apis#15 for the concrete use case.
domenic
force-pushed
the
double-progressevent
branch
from
48e8e0d to
5b4e883
Compare
|
Should be fine. |
annevk
approved these changes
Jan 22, 2025
|
Awesome. I'm hoping to delegate the implementation and tests to someone else so it might be a week or so, but once we have tests up I'll update this thread with a link to them and open other-browser bugs. And I'll ping again once we have it shipped. |
domenic
added a commit
to webmachinelearning/writing-assistance-apis
that referenced
this pull request
Jan 24, 2025
Closes #15. Depends on whatwg/xhr#394.
domenic
added a commit
to webmachinelearning/writing-assistance-apis
that referenced
this pull request
Jan 24, 2025
Closes #15. Depends on whatwg/xhr#394.
domenic
added a commit
to webmachinelearning/writing-assistance-apis
that referenced
this pull request
Jan 24, 2025
Closes #15. Depends on whatwg/xhr#394.
|
Bug with a patch https://bugzilla.mozilla.org/show_bug.cgi?id=1943649 (webidl codegen for events is nice in this case) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specifications to use ProgressEvents while not necessarily giving away the exact number of bytes, for example by using numbers between 0 and 1. See discussion in webmachinelearning/writing-assistance-apis#15 for the concrete use case.
ProgressEventbehavior changes: fractions are preserved, and negatives are now passed through as-is instead of subtracted from 2^64.(See WHATWG Working Mode: Changes for more details.)
I wanted to get this PR up to judge implementer interest. It would be a decent bit cleaner if we all agreed this was reasonable and merged the change now, instead of having to float a patch in the relevant specs and thus causing all the databases to have two definitions of
ProgressEvent.Preview | Diff