-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 0.3.4+8.13.34 #67
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 71.81% 71.86% +0.05%
==========================================
Files 19 19
Lines 1955 1955
==========================================
+ Hits 1404 1405 +1
+ Misses 551 550 -1 ☔ View full report in Codecov by Sentry. |
Why is this still not merged? The DB shipped with this crate is now over a year old. Is there anything we can do to help? I could also make a PR for the DB from last week (8.13.34) + fixed warnings + bumped dependencies as I have a version with those changes. But before I do that I'd like to know what the chances are, of that being accepted. 😁 |
I was mostly waiting on a second pair of eyes from @gferon, actually. |
On it, I'll check right now! I think we wanted to first merge another PR and completely forgot about it. |
If you have it around, feel free to push that instead! Maybe make a separate PR for the version bump though! |
Just released the new version on |
Bump version and update underlying dataset to the latest release at https://github.com/google/libphonenumber/releases/tag/v8.13.34.