Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.3.4+8.13.34 #67

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Bump version to 0.3.4+8.13.34 #67

merged 4 commits into from
Apr 11, 2024

Conversation

rubdos
Copy link
Member

@rubdos rubdos commented Dec 14, 2023

Bump version and update underlying dataset to the latest release at https://github.com/google/libphonenumber/releases/tag/v8.13.34.

@rubdos rubdos requested a review from gferon December 14, 2023 15:00
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (1f46da5) to head (0cf3934).
Report is 3 commits behind head on main.

❗ Current head 0cf3934 differs from pull request most recent head 5e1a662. Consider uploading reports for the commit 5e1a662 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   71.81%   71.86%   +0.05%     
==========================================
  Files          19       19              
  Lines        1955     1955              
==========================================
+ Hits         1404     1405       +1     
+ Misses        551      550       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@virtualritz
Copy link
Contributor

virtualritz commented Apr 11, 2024

Why is this still not merged? The DB shipped with this crate is now over a year old.

Is there anything we can do to help?

I could also make a PR for the DB from last week (8.13.34) + fixed warnings + bumped dependencies as I have a version with those changes.

But before I do that I'd like to know what the chances are, of that being accepted. 😁

@rubdos
Copy link
Member Author

rubdos commented Apr 11, 2024

Why is this still not merged?

I was mostly waiting on a second pair of eyes from @gferon, actually.

@gferon
Copy link
Contributor

gferon commented Apr 11, 2024

On it, I'll check right now! I think we wanted to first merge another PR and completely forgot about it.

@rubdos
Copy link
Member Author

rubdos commented Apr 11, 2024

I could also make a PR for the DB from last week (8.13.34) + fixed warnings + bumped dependencies as I have a version with those changes.

But before I do that I'd like to know what the chances are, of that being accepted. 😁

If you have it around, feel free to push that instead! Maybe make a separate PR for the version bump though!

@gferon gferon changed the title Bump version to 0.3.4+8.13.26 Bump version to 0.3.4+8.13.34 Apr 11, 2024
@gferon
Copy link
Contributor

gferon commented Apr 11, 2024

Why is this still not merged?

I suppose CI failed or something else happened, actually 🤔

Screenshot 2024-04-11 at 20 47 11

I updated the assets to v8.13.34 and will merge this and publish to crates.io afterwards!

@gferon gferon merged commit 210d8df into main Apr 11, 2024
6 checks passed
@gferon gferon deleted the 0.3.4 branch April 11, 2024 18:59
@gferon
Copy link
Contributor

gferon commented Apr 11, 2024

Just released the new version on crates.io - https://crates.io/crates/phonenumber/0.3.4+8.13.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants