-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON exports #344
JSON exports #344
Conversation
@@ -29,7 +29,7 @@ | |||
# This allows us to inject a custom version into setuptools using the | |||
# environment variable: WTM_VERSION. If it is not specified, a default value is | |||
# used, but you will not be able to run sdist in this case. | |||
DEFAULT_VERSION = "dev" | |||
DEFAULT_VERSION = "0.dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to be changed? I have not run test, but I never changed the default. I wonder if it will introduce subtle regressions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK, it fails on me with just dev
. from what I understand setuptools does not support dev
as a valid version name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing it from "dev" to "0.dev" did not have a noticeable effect in my setup. Thus, I'm fine with changing it.
I assume, it comes from some semantic versioning naming conventions, which require it to start with an integer. "0.devN" seems more common.
I wonder if it is also related to the README?
Line 121 in ebe5b85
$ python -m pip install -e '.[dev]' |
Line 145 in ebe5b85
$ python -m pip install -e '.[dev]' |
But the commands from the README still seem to work for me.
I would see Line 142 in ebe5b85
|
For each website, do not only export the static HTML, but also dump out the data used to generate the graphs.