Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize a bit #5

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

modernize a bit #5

wants to merge 9 commits into from

Conversation

hoijui
Copy link
Contributor

@hoijui hoijui commented Jun 15, 2019

these are the main changes:

  • switch to CMake
  • restrucutre
  • use Travis-CI

@wickedchicken
Copy link
Owner

Hi @hoijui, thank you for the PR!

I'm in the process of importing sndpeek 1.4 into this codebase. When done I'll take a look at your changes and see how they can be rebased onto the new code.

@hoijui
Copy link
Contributor Author

hoijui commented Aug 6, 2019

cool! :-)
tel me if it gets too much and I should help.

@wickedchicken
Copy link
Owner

Ok, I've just merged in #6. Since I don't know cmake at all, I'd like to apply your changes in 2 steps:

  1. Add Travis CI (and AppVeyor?) to verify that things compile the old way
  2. Apply your changes, so now we can show that the new changes work everywhere

I'll get started with 1, and hope I can get something before the end of the week. Then I can take your changes and work through understanding how cmake works :).

Hopefully that sounds like a good plan to you.

@hoijui
Copy link
Contributor Author

hoijui commented Aug 8, 2019

sounds good! :-)

just the VERY most basic about CMake (as I don't know what you already know):
It is a meta-build system; a build system that generates other build systems, for example a Makefile or a VisualStudio project (file).

@wickedchicken
Copy link
Owner

wickedchicken commented Aug 21, 2019

Hey, I just wanted to say that I pulled your Travis change (pre-cmake) into #7. I'm still working on Windows support, unfortunately it's a bit trickier than I expected...

@hoijui
Copy link
Contributor Author

hoijui commented Aug 21, 2019

mmm nice! :-)

ouhh... I did not know it is supposed to work with windows too. ok!
I am no windows expert, but I did make some stuff work there too, so shout if you need help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants