-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernize a bit #5
base: master
Are you sure you want to change the base?
Conversation
Hi @hoijui, thank you for the PR! I'm in the process of importing sndpeek 1.4 into this codebase. When done I'll take a look at your changes and see how they can be rebased onto the new code. |
cool! :-) |
Ok, I've just merged in #6. Since I don't know
I'll get started with 1, and hope I can get something before the end of the week. Then I can take your changes and work through understanding how Hopefully that sounds like a good plan to you. |
sounds good! :-) just the VERY most basic about CMake (as I don't know what you already know): |
Hey, I just wanted to say that I pulled your Travis change (pre-cmake) into #7. I'm still working on Windows support, unfortunately it's a bit trickier than I expected... |
mmm nice! :-) ouhh... I did not know it is supposed to work with windows too. ok! |
these are the main changes: