more failsafe check if date conversion fails

wielebenwir · Feb 11, 2025 · be3cedc · be3cedc
1 parent ba3291b
commit be3cedc
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/Repository/TimeframeRelations.php b/src/Repository/TimeframeRelations.php
@@ -37,12 +37,13 @@ public static function insertTimeframe ( \CommonsBooking\Model\Timeframe $timefr
 
         $endTimestamp = $timeframe->getEndDate();
 
-        if ($endTimestamp == 0 || empty($endTimestamp)) {
-            //$EndDateTime = date('Y-m-d H:i:s', strtotime("+90 days"));
-	        $EndDateTime = 'NULL';
-        } else {
-            $EndDateTime = date('Y-m-d H:i:s', $endTimestamp);
-        }
+		$dateConversionFails = false === date( 'Y-m-d H:i:s', $endTimestamp );
+		if ( $endTimestamp == 0 || empty( $endTimestamp ) || $dateConversionFails ) {
+			//$EndDateTime = date('Y-m-d H:i:s', strtotime("+90 days"));
+			$EndDateTime = 'NULL'; // TODO as 9999-01-01... in case of non-null enddatetime column change
+		} else {
+			$EndDateTime = date( 'Y-m-d H:i:s', $endTimestamp );
+		}
 
 
 		if (self::hasTimeframe($timeframe)) {