Add phpcbf check workflow #1761
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PHP Code Beautifier and Fixer found the following fixable issues, fix them first to ammend to contribution guidelines. |
|
Das sollte ja eigentlich fehlschlagen, oder? So zumindest der Log von phpcbf: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running phpcbf on our codebase (#1730), this adds an automatic check, if we have any code format violations in future prs and suggests running phpcbf by the user.
Additionally I think it would be more comfortable for contributors to have an pre-commit hook, that checks if phpcbf should be run.
TODO