-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config for V18 + allow router + util to generate config for new metrics #10
base: master
Are you sure you want to change the base?
Conversation
add overlord to allowed druid daemon names
…rom the exporter output * - add router to daemon names + route conf * - Add router to allowed daemons * - Add labels to all metric definition * - Add utility to generate new metrics from log * - Add SQL metrics to briker * - Do not process same metric twice * - Those also can be labels for prometheus * - This is elif * - Add more possible labels for metrics + refactor * - More missing metrics for V018 * - More missgin metrics * - More memory missing metrics for router and broker
@rafitadiaz thanks a lot for the pull request, it looks awesome! Just wanted to say that I am aware of it but didn't have the time to review it yet, I promise some feedback next week! |
I have reviewed the patch and I have few ideas, let me know what you think about them. I would split the pull request into two/three parts:
About the first two: this is a mirror only repo sadly, so I cannot merge anything from GH. The real repo is on Gerrit Wikimedia (gerrit.wikimedia.org), you can register your user, clone the repo and execute something like About the utils section: I am wondering if, in the interest of keeping this repo as slim as possible, we could create a new repo for the tool (maybe under you user in GH) and add a "Tools" section in this repo's readme, linking to your tool (with some description etc..). What do you think? If more people add tools (that would be great) it will be more scalable, since different code bases could have different dev workflows. |
Sure, I would be happy to do it. |
@rafitadiaz Thanks a lot! For the moment I'd prefer a separate repo if possible, will wait for the other pull requests then :) |
So basically it converts this:
into this:
So basically you just need to review if the config is OK and copy it in the right place inside the Json file.