Merge pull request #5141 from wikimedia/revert-5135-analytics-yir-bugfix

Revert "[YiR] Analytics update"
wikimedia · Jan 10, 2025 · 68871eb · 68871eb
2 parents 5e7a6b5 + 6315775
commit 68871eb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/Wikipedia/Code/DonateFunnel.swift b/Wikipedia/Code/DonateFunnel.swift
@@ -360,6 +360,10 @@ import WMF
         logEvent(activeInterface: .wikiYiR, action: .impression, actionData: ["slide": "new_account_engage"])
     }
 
+    func logYearInReviewLoginPromptDidAppearProfile() {
+        logEvent(activeInterface: .wikiYiR, action: .impression, actionData: ["slide": "yir_start_account_engage"])
+    }
+
     func logYearInReviewLoginPromptDidTapLogin() {
         logEvent(activeInterface: .wikiYiR, action: .accountEngageClick, actionData: ["slide": "new_account_engage"])
     }
@@ -373,7 +377,7 @@ import WMF
     }
 
     func logYearInReviewLoginPromptDidTapNoThanksProfile() {
-        logEvent(activeInterface: .wikiYiR, action: .rejectClick, actionData: ["slide": "entry_b_profile"])
+        logEvent(activeInterface: .wikiYiR, action: .rejectClick, actionData: ["slide": "yir_start_account_engage"])
     }
 
     func logYearInReviewDidTapShare(slideLoggingID: String) {

diff --git a/Wikipedia/Code/ProfileCoordinator.swift b/Wikipedia/Code/ProfileCoordinator.swift
@@ -220,6 +220,8 @@ final class ProfileCoordinator: NSObject, Coordinator, ProfileCoordinatorDelegat
             alert.addAction(action2)
 
             presentedViewController.present(alert, animated: true)
+
+            DonateFunnel.shared.logYearInReviewLoginPromptDidAppearProfile()
         }
     }
-Original file line number
+Diff line change
@@ Expand Up @@
                 alert.addAction(action2)
                 presentedViewController.present(alert, animated: true)
+                DonateFunnel.shared.logYearInReviewLoginPromptDidAppearProfile()
             }
         }
@@ Expand Down @@