Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Headers: Search #5167

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Standardize Headers: Search #5167

wants to merge 3 commits into from

Conversation

l-olson1214
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T383825

Notes

  • Does not move clear (see comments in ticket)

Test Steps

  1. Enter several items in search to build up a recent search history
  2. Navigate to search
  3. Make sure scroll behavior works as expected
  4. Ensure profile is there and usable
  5. Check the same in landscape
  6. Repeat in iPad

Screenshots/Videos

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-23.at.14.32.36.mp4

Simulator Screenshot - iPhone 15 Pro - 2025-01-23 at 14 32 08
Simulator Screenshot - iPhone 15 Pro - 2025-01-23 at 14 32 13

@l-olson1214 l-olson1214 requested review from a team and mazevedofs and removed request for a team January 23, 2025 21:04
@l-olson1214 l-olson1214 changed the title Add profile to search Standardize Headers: Search Jan 23, 2025
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're having the same issues I had on the Places tab regarding theming (the button's theme doesn't update and the settings and notifications controllers also do not update to the new theme)
To fix it, inside override func apply(theme: Theme) ... add two lines
updateProfileButton() // your update func here
profileCoordinator.theme = theme

that should fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants