Update Done/cancel buttons #5168
Conversation
mazevedofs
requested review from
a team and
tonisevener
and removed request for
a team
mazevedofs
force-pushed
the
done-button
branch
from
f50cac1 to
6541f52
Compare
There was a problem hiding this comment.
Thanks, these mostly look good, found one regression (commented on appropriate file). I also found some that weren't updated:
For the two factor and change temp, I had to fudge some code to even enter that screen.
I also found one double Done button situation that was missed, we should ask design for instruction here:
Settings > My Languages > Add another language so you have multiple > See Edit button, tap it:
Lastly, there's a series of other pieces of feedback, but they seem a bit more involved due to changing existing X buttons into a label. Maybe we can break that off into a separate task? I would like to prioritize them separately at least, for the chance that they will be deprioritized to a later release.
Article Gallery
Article TOC
Article References
Editor Find in Page
| @@ -181,7 +181,7 @@ class SinglePageWebViewController: ThemeableViewController, WMFNavigationBarConf | |||
| let titleConfig = WMFNavigationBarTitleConfig(title: "", customView: nil, alignment: .hidden) | |||
|
|
|||
| if navigationController?.viewControllers.first === self { | |||
| closeConfig = WMFNavigationBarCloseButtonConfig(text: CommonStrings.doneTitle, target: self, action: #selector(closeButtonTapped(_:)), alignment: .leading) | |||
| closeConfig = WMFNavigationBarCloseButtonConfig(text: CommonStrings.cancelActionTitle, target: self, action: #selector(closeButtonTapped(_:)), alignment: .leading) | |||
There was a problem hiding this comment.
This fixes the Year in Review > Donate > Other Payment Method modal, but causes a regression with Article > Edit Article Description > Learn More:
12 Article > Article Description Edit > Learn More
✅ Keep it as is
Changed to:
Phabricator: https://phabricator.wikimedia.org/T383460
Notes
Test Steps