Standardize Headers: History #5169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonisevener
requested changes
Jan 24, 2025
|
|
||
| let profileButtonConfig: WMFNavigationBarProfileButtonConfig? | ||
| if let dataStore { | ||
| profileButtonConfig = self.profileButtonConfig(target: self, action: #selector(userDidTapProfile), dataStore: dataStore, yirDataController: yirDataController, leadingBarButtonItem: nil, trailingBarButtonItem: nil) |
There was a problem hiding this comment.
Code so far looks good - I noticed the Clear button disappeared though, unfortunately. I did a bit of digging and for mysterious reasons of the past that logic is buried in the superclass ArticleFetchedResultsViewController, but only this subclass takes advantage of it (due to it setting isDeleteAllVisible = true).
Can you move the Clear button-related logic out of ArticleFetchedResultsViewController and into HistoryViewController? Then on this line you can hopefully set the leadingBarButtonItem parameter to a clear button lazy property on self.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T383826
Notes
Test Steps
Screenshots/Videos