Split Agent and Session for per-session use-cases #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@baloo I'd really like you to take a look at this. I think it offers vastly superior functionality compared to the old "all-in-Agent" code :) |
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
wiktor-k
force-pushed
the
wiktor/session-agent-split
branch
from
d4ac8d5 to
f4e068b
Compare
baloo
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits Agent activities (listening and creating sessions) and Session activities (handling messages) into two separate traits allowing per-session state to be stored.
New code should implement
Sessionand eitherDefault(if no session state is required) orAgent::new_sessionif a specialized Session object is required.This provides minimal changes to existing clients but also allows more flexible behavior.