Relicense the library to MIT/Apache 2.0 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
commented
Apr 5, 2024
|
Folks (@jcspencer, @baloo), this has been suggested in the zulip/rust crypto thread and I think it's a perfect opportunity to do it now but since you two contributed significant changes I'd like your explicit acks on it (this is not super-urgent). |
wiktor-k
force-pushed
the
relicense-to-apl-plus-mit
branch
from
7daa7ba to
cf71ac2
Compare
|
ack from me! |
|
Ack from me. |
baloo
force-pushed
the
relicense-to-apl-plus-mit
branch
from
cf71ac2 to
4b623ba
Compare
Due to MIT/Apache 2.0 combination being more widespread in Rust and due to the fact that the library has basically been almost completely rewritten it has been suggested that this is a perfect opportunity to adjust the license. See: https://rustcrypto.zulipchat.com/#narrow/stream/346919-SSH/topic/Bring.20in.20ssh-agent-lib/near/431145569 Fixes: #35 Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
baloo
force-pushed
the
relicense-to-apl-plus-mit
branch
from
4b623ba to
ef1c75e
Compare
tarcieri
reviewed
Apr 16, 2024
Signed-off-by: Arthur Gautier <[email protected]>
baloo
force-pushed
the
relicense-to-apl-plus-mit
branch
from
ef1c75e to
2efbf2f
Compare
wiktor-k
commented
Apr 17, 2024
Signed-off-by: Arthur Gautier <[email protected]>
baloo
force-pushed
the
relicense-to-apl-plus-mit
branch
from
516e645 to
aca25df
Compare
|
Thanks for taking care of this @baloo 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to MIT/Apache 2.0 combination being more widespread in Rust and due to the fact that the library has basically been almost completely rewritten it has been suggested that this is a perfect opportunity to adjust the license.
See: https://rustcrypto.zulipchat.com/#narrow/stream/346919-SSH/topic/Bring.20in.20ssh-agent-lib/near/431145569
README.md rendered