extension: impl Encode for known extensions
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This blows the work I committed in #45 out of the water - splitting out the |
wiktor-k
reviewed
Apr 18, 2024
|
Looks good, please update on top of |
wiktor-k
approved these changes
Apr 18, 2024
This also splits the `DestinationConstraints` implementation in a subtype for ease and readability. Signed-off-by: Arthur Gautier <[email protected]>
baloo
force-pushed
the
baloo/encode-extensions
branch
from
d761362 to
ab7f20c
Compare
|
Ship it, ship it! 🚀 |
baloo
added a commit
to baloo/ssh-agent-lib
that referenced
this pull request
Apr 18, 2024
The implementation of wiktor-k#48 was incorrect Signed-off-by: Arthur Gautier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also splits the
DestinationConstraintsimplementation in a subtype for ease and readability.