Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused &mut self in key constraint extension parsing #59

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

jcspencer
Copy link
Collaborator

Following on from #58, I noticed that key constraint extensions don't need &mut self in method calls either.

Thanks for the pickup @baloo!

Copy link
Owner

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks!

@wiktor-k wiktor-k merged commit 7472903 into main Apr 25, 2024
16 checks passed
@wiktor-k wiktor-k deleted the jcspencer/unused-mut-key-constraint branch April 25, 2024 06:49
@baloo
Copy link
Collaborator

baloo commented Apr 25, 2024

One would have assumed I could have read through the other items of the struct 🤡 .

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants