Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18460] bmt Quickstart Common Enhancements CY2023Q3 #748

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

marcosgopen
Copy link
Contributor

@marcosgopen marcosgopen commented Oct 16, 2023

link: https://issues.redhat.com/browse/WFLY-18460

Note: Openshift test fails because in the current quickstart (main branch) there isn't the provisioned-server profile, so the build-artifact step will fail. To work it around you could test this PR locally changing the helm.yaml file with:

build:
  uri: https://github.com/marcosgopen/quickstart-wildfly.git
  ref: WFLY-18460
  contextDir: bmt
deploy:
  replicas: 1

Once the PR is merged this issue gets solved.

@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2023

Hi @marcosgopen. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marcosgopen
Copy link
Contributor Author

As I had a conflict on the server version I rebased the PR. Now the server.version is 30.0.0.Final instead of 30.0.0.Beta1

bmt/pom.xml Outdated Show resolved Hide resolved
bmt/README.adoc Outdated Show resolved Hide resolved
@kabir
Copy link
Contributor

kabir commented Oct 20, 2023

@marcosgopen to test on OpenShift use --set overrides when installing the Helm chart, i.e.:

helm install myqs -f charts/helm.yml --set build.uri=https://github.com/marcosgopen/quickstart-wildfly.git --set build.ref=WFLY-18460

That is what the OpenShift CI testing does

@kabir
Copy link
Contributor

kabir commented Oct 20, 2023

/ok-to-test

@marcosgopen
Copy link
Contributor Author

@marcosgopen to test on OpenShift use --set overrides when installing the Helm chart, i.e.:

helm install myqs -f charts/helm.yml --set build.uri=https://github.com/marcosgopen/quickstart-wildfly.git --set build.ref=WFLY-18460

That is what the OpenShift CI testing does

Thanks @kabir , very handy +1

@emmartins emmartins merged commit a20ed49 into wildfly:main Oct 20, 2023
@emmartins
Copy link
Contributor

thank you @marcosgopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants