-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-18508 spring-resteasy Quickstart Common Enhancements CY2023Q3 #755
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: WildFly spring-resteasy Quickstart CI | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, ready_for_review] | ||
| paths: | ||
| - 'spring-resteasy/**' | ||
| - '.github/workflows/quickstart_ci.yml' | ||
| jobs: | ||
| call-quickstart_ci: | ||
| uses: ./.github/workflows/quickstart_ci.yml | ||
| with: | ||
| QUICKSTART_PATH: spring-resteasy | ||
| TEST_PROVISIONED_SERVER: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| build: | ||
| uri: https://github.com/wildfly/quickstart.git | ||
| ref: main | ||
| contextDir: spring-resteasy | ||
| deploy: | ||
| replicas: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
...g-resteasy/src/test/java/org/jboss/as/quickstarts/resteasyspring/test/BasicRuntimeIT.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /* | ||
| * Copyright 2023 JBoss by Red Hat. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.jboss.as.quickstarts.resteasyspring.test; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import java.io.IOException; | ||
| import java.net.URI; | ||
| import java.net.URISyntaxException; | ||
| import java.net.http.HttpClient; | ||
| import java.net.http.HttpRequest; | ||
| import java.net.http.HttpResponse; | ||
| import java.time.Duration; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| /** | ||
| * The very basic runtime integration testing. | ||
| * @author liweinan | ||
| */ | ||
| public class BasicRuntimeIT { | ||
|
|
||
| private static final String DEFAULT_SERVER_HOST = "http://localhost:8080/spring-resteasy"; | ||
|
|
||
| @Test | ||
| public void testHTTPEndpointIsAvailable() throws IOException, InterruptedException, URISyntaxException { | ||
| String serverHost = System.getenv("SERVER_HOST"); | ||
| if (serverHost == null) { | ||
| serverHost = System.getProperty("server.host"); | ||
| } | ||
| if (serverHost == null) { | ||
| serverHost = DEFAULT_SERVER_HOST; | ||
| } | ||
| final HttpRequest request = HttpRequest.newBuilder() | ||
| .uri(new URI(serverHost+"/")) | ||
| .GET() | ||
| .build(); | ||
| final HttpClient client = HttpClient.newBuilder() | ||
| .followRedirects(HttpClient.Redirect.ALWAYS) | ||
| .connectTimeout(Duration.ofMinutes(1)) | ||
| .build(); | ||
| final HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString()); | ||
| assertEquals(200, response.statusCode()); | ||
| assertTrue(response.body().toString().contains("Hello.")); | ||
|
|
||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need also plugin management to be added, please see https://docs.google.com/document/d/1GFnZrnlwRkwC0HfziRws2UUWR99KdaQayA7Ei12SGN4/edit#heading=h.rcftxwtudvl5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmartins I have added the plugin management section, not sure I add it correctly or not. In addition I found the
batch-proessingexample doesn't have this section either:Shall I add the section their too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is not a MicroProfile quickstart you don't need the wildfly-jar plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrt batch-processing it was fixed yesterday :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!