[WFLY-18499] Update the microprofile-rest-client for the Common Enhan… #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
force-pushed
the
WFLY-18499
branch
2 times, most recently
from
194a3a0 to
59dba33
Compare
emmartins
requested changes
Nov 27, 2023
| <groupId>org.wildfly.plugins</groupId> | ||
| <artifactId>wildfly-maven-plugin</artifactId> | ||
| <version>${version.plugin.wildfly}</version> | ||
| <configuration> |
There was a problem hiding this comment.
considering that we won't have provisioned-server profile (see below), this config is no longer needed
There was a problem hiding this comment.
If we remove this, then it can't be used for development. Why not just keep it?
There was a problem hiding this comment.
Actually, this is needed for the openshift profile.
There was a problem hiding this comment.
I meant only the configuration part, not the plugin management itself, the openshift profile uses full config.
jamezp
force-pushed
the
WFLY-18499
branch
3 times, most recently
from
1410d49 to
8dc74d4
Compare
emmartins
requested changes
Nov 27, 2023
| <groupId>org.wildfly.plugins</groupId> | ||
| <artifactId>wildfly-maven-plugin</artifactId> | ||
| <version>${version.plugin.wildfly}</version> | ||
| <configuration> |
There was a problem hiding this comment.
I meant only the configuration part, not the plugin management itself, the openshift profile uses full config.
emmartins
approved these changes
Nov 27, 2023
…cements. Refactor the quickstart to a single module with a test for the MicroProfile REST Client. Signed-off-by: James R. Perkins <[email protected]>
|
There are a few issues on README that I only noticed post merge, I will send a PR wrt that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cements. Refactor the quickstart to a single module with a test for the MicroProfile REST Client.
https://issues.redhat.com/browse/WFLY-18499