Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18513] websocket-endpoint quickstart enhancement CY2023Q3 #798

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

istudens
Copy link
Contributor

@istudens istudens commented Dec 5, 2023

Copy link

openshift-ci bot commented Dec 5, 2023

Hi @istudens. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istudens
Copy link
Contributor Author

istudens commented Dec 5, 2023

@emmartins Can you review this please? Thanks

@emmartins
Copy link
Contributor

@istudens quickstart_websocket-endpoint_ci.yml is missing, I will test everything else now

Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything other than the missing yml is good.

@istudens
Copy link
Contributor Author

istudens commented Dec 7, 2023

@emmartins the missing CI yaml file added

Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you Ivo, great work!

@emmartins emmartins merged commit fe75d9d into wildfly:main Dec 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants