Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18464] ejb-multi-server Quickstart Common Enhancements CY2023Q3 #875

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

emmartins
Copy link
Contributor

Issue: https://issues.redhat.com/browse/WFLY-18464

Changes on top of #842:

  • Renamed workflow to correct filename: quickstart_ejb-multi-server_ci.yml
  • Moved workflow to correct directory: /.github/workflows (not ejb-multi-server/.github/workflows)
  • Fixed content in the workflow
  • Replaced custom sections in README with includes for related ones in shared-docs, wrt deploy and undeploy (and removed ref to standalone start in that deploy section)
  • Added include of integration tests section from shared-docs (and added customization of test sources dir in it)
  • Removed unused cli scripts to deploy and undeploy domain
  • Fixed plugin management for wildfly maven plugin
  • Updated server.version value

@emmartins emmartins added the hold do not merge label Feb 7, 2024
@emmartins
Copy link
Contributor Author

emmartins commented Feb 7, 2024

hi @tadamski , I created this PR on top of the commits you did at #842 , please review my commit changes (see PR description above for details on those), if you agree I will squash all commits and merge this instead of #842

Btw, answering your doubts there sure it's fine to limit the scope of this QS due to complexity, and thus skip server provisioning and openshift.

I believe there is much to improve wrt integration testing, such as replacing the client's exec:java with an integration test, which could even be just an invocation of "http://localhost:8380/ejb-multi-server-app-web" and verify response content, but we can discuss that later as a followup.

@emmartins
Copy link
Contributor Author

@tadamski ^^

Copy link
Contributor

@tadamski tadamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmartins LGTM, thanks!

@emmartins emmartins removed the hold do not merge label Feb 19, 2024
@emmartins emmartins merged commit 1c6daae into wildfly:main Feb 19, 2024
20 checks passed
@emmartins emmartins deleted the WFLY-18464 branch February 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants