Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6960]: Promote Simple config export for a server as an attachment from COMMUNITY to DEFAULT. #6147

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

ehsavoie
Copy link
Contributor

  • Adding more test using the CLI.
  • Moving from COMMUNITY to DEFAULT
  • Renaming the ManagementReadXmlCommunityTestCase to ManagementReadXmlAsFileTestCase.

Jira: https://issues.redhat.com/browse/WFCORE-6960
Proposal: wildfly/wildfly-proposals#594

@ehsavoie ehsavoie added the Feature This PR adds a new feature to WildFly label Aug 28, 2024
@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Aug 28, 2024
@wildfly-ci

This comment was marked as outdated.

@yersan yersan added the missing-reqs This PR is missing external requirements before it can be merged label Sep 2, 2024
Copy link

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM, and they reflect what in the community proposal and related feature test plan.
I see CI checks are failing but it seems that's about an unrelated test. Approving from QA perspective

@ehsavoie ehsavoie force-pushed the WFCORE-6960 branch 2 times, most recently from 22a7164 to c4c46f4 Compare September 6, 2024 15:24
…ment from COMMUNITY to DEFAULT.

* Adding more test using the CLI.
* Moving from COMMUNITY to DEFAULT
* Renaming the ManagementReadXmlCommunityTestCase to
  ManagementReadXmlAsFileTestCase.

Jira: https://issues.redhat.com/browse/WFCORE-6960

Signed-off-by: Emmanuel Hugonnet <[email protected]>
@yersan yersan added ready-for-merge This PR is ready to be merged and fulfills all requirements and removed missing-reqs This PR is missing external requirements before it can be merged labels Sep 19, 2024
@yersan yersan merged commit 11f4c70 into wildfly:main Sep 19, 2024
11 of 12 checks passed
@yersan
Copy link
Collaborator

yersan commented Sep 19, 2024

Thanks @ehsavoie @fabiobrz @darranl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes Feature This PR adds a new feature to WildFly ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants