[WFCORE-7102]: AccessDeniedException on Windows when using a read-only #6287
Conversation
|
thanks @ehsavoie , Ideally, we should enable this test for Windows with this PR: https://github.com/wildfly/wildfly-core/blob/main/testsuite/manualmode/src/test/java/org/jboss/as/test/manualmode/management/ReadOnlyModeTestCase.java#L72-L74 But I know there are currently issues setting a read-only directory in the code since the CI won't be able to delete it. We can discuss it with @luck3y if there is any way to enable that permissions for Windows OS |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hi Yeray,
You should be able to create a directory in Windows and mark it read only,
ideally reversing the read only bit when the test is done. I don't think
any special permissions are required as long as you stay within the
checkout directory in CI.
Ken
…On Tue, Dec 17, 2024, 10:53 Yeray Borges ***@***.***> wrote:
thanks @ehsavoie <https://github.com/ehsavoie> , Ideally, we should
enable this test for Windows with this PR:
https://github.com/wildfly/wildfly-core/blob/main/testsuite/manualmode/src/test/java/org/jboss/as/test/manualmode/management/ReadOnlyModeTestCase.java#L72-L74
But I know there are currently issues setting a read-only directory in the
code since the CI won't be able to delete it. We can discuss it with
@luck3y <https://github.com/luck3y> if there is any way to enable that
permissions for Windows OS
—
Reply to this email directly, view it on GitHub
<#6287 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC7HAFYPUJN7DZHZDR5AGD2GBJHXAVCNFSM6AAAAABTY25IICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBZGAZDAMBQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ehsavoie
force-pushed
the
WFCORE-7102
branch
from
bc35440 to
eb328cc
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Weird, test still appears as ignored in Windows: https://ci.wildfly.org/buildConfiguration/WildFlyCore_PullRequest_WindowsJdk11/476232?buildTab=tests&name=ReadOnlyModeTestCase&suite=&package=org.jboss.as.test.manualmode.management WDYT @ehsavoie ? |
This comment was marked as outdated.
This comment was marked as outdated.
ehsavoie
force-pushed
the
WFCORE-7102
branch
2 times, most recently
from
bd7f05f to
eb173c8
Compare
|
@yersan This is properly fixed now and it works |
ehsavoie
force-pushed
the
WFCORE-7102
branch
4 times, most recently
from
d0b7664 to
6f5d3fa
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
I've made some trivial change requests. I've not tried to understand the meat of this, so please don't regard fixing my requests as an approval; rely on the others who are reviewing.
OTOH, mergers please don't block on my re-reviewing my trivial items before merging.
server/src/main/java/org/jboss/as/server/operations/ServerProcessReloadHandler.java
Outdated
Show resolved
Hide resolved
...e/manualmode/src/test/java/org/jboss/as/test/manualmode/management/ReadOnlyModeTestCase.java
Outdated
Show resolved
Hide resolved
...e/manualmode/src/test/java/org/jboss/as/test/manualmode/management/ReadOnlyModeTestCase.java
Outdated
Show resolved
Hide resolved
|
@luck3y Please review. |
|
|
||
| Files.getFileAttributeView(roConfigDir, PosixFileAttributeView.class).setPermissions(perms); | ||
|
|
||
| if (TestSuiteEnvironment.isWindows()) { |
There was a problem hiding this comment.
This seems odd to me, for Windows an ACL is constructed that denies the listed permissions, which seems correct, but on all other OSes are added as allowed. I'm probably missing something here though?
There was a problem hiding this comment.
Well 1st, I only looked at Windows but the problem is that the permissions are quite complex with a lot of principals so I reduced the change to the owner only and removing a permission isn't sufficient in Windows you have to DENY it.
...e/manualmode/src/test/java/org/jboss/as/test/manualmode/management/ReadOnlyModeTestCase.java
Outdated
Show resolved
Hide resolved
…y configuration dir. * Replacing java.io.File.canWrite() by java.nio.file.Files.isWritable(Path) in: - ConfigurationFile - FilePersistenceUtils - ConfigurationFilePersistenceResource * Enabling the test for Windows and chaning the temp folder creation Jira: https://issues.redhat.com/browse/WFCORE-7102 Signed-off-by: Emmanuel Hugonnet <[email protected]>
bstansberry
dismissed
their stale review
The trivial items I mentioned have been addressed.
LGTM too, I looked at the code again, its only adding read and execute, no write, so I must have misread it the first time. |
configuration dir.
Jira: https://issues.redhat.com/browse/WFCORE-7102