Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFDISC-54] Do not cancel DiscoveryAttempt connection creation if oth… #69

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

tadamski
Copy link
Contributor

@tadamski tadamski commented Mar 1, 2024

…er node has provided the result already

@dmlloyd
I'm opening this PR as a follow up to discussion in #68:

  • I have just modified the close method, but I don't believe removing cancellation handlers is appropriate as there possibly may be some other trigger for cancellation and that has to be taken into account
  • Removing cancellation fixes the intial problem in WFTC-53
  • I have also run wildfly integration tests to double check if this removal causes some unanticipated problem but all seems fine
  • I was concerned whether this change may lead to attempts of many connection creation if there are some problems with connection establishment but looking at ClientServiceHandle code imho this should work fine as well.

@tadamski tadamski merged commit 75ad537 into wildfly:master Mar 2, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants