Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #95, Introduce a rule for a layer to express that it requires some user selected add-ons #96

Closed
wants to merge 1 commit into from
Closed

Fix Issue #95, Introduce a rule for a layer to express that it requires some user selected add-ons #96

wants to merge 1 commit into from

Conversation

jfdenise
Copy link
Contributor

Issue: #95

@jfdenise jfdenise requested a review from a team as a code owner November 22, 2024 14:59
bstansberry
bstansberry requested changes Nov 22, 2024
View reviewed changes
Copy link

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfdenise you'll need to ping me in zulip when you need a new review as I'm unlikely to notice otherwise.

core/src/main/java/org/wildfly/glow/SelectionMode.java Outdated Show resolved Hide resolved
core/src/main/java/org/wildfly/glow/GlowSession.java Outdated Show resolved Hide resolved
core/src/main/java/org/wildfly/glow/GlowSession.java Outdated Show resolved Hide resolved
...test-feature-pack/galleon-pack/src/main/resources/layers/standalone/f1-add-on/layer-spec.xml Outdated Show resolved Hide resolved
...est-feature-pack/galleon-pack/src/main/resources/layers/standalone/f1-add-on2/layer-spec.xml Outdated Show resolved Hide resolved
core/src/main/java/org/wildfly/glow/SelectionMode.java Outdated Show resolved Hide resolved
...ests/src/test/java/org/wildfly/glow/rules/test/addon/select/family/SelectFamilyTestCase.java Outdated Show resolved Hide resolved
core/src/main/java/org/wildfly/glow/SelectionMode.java Outdated Show resolved Hide resolved
@jfdenise jfdenise marked this pull request as draft November 25, 2024 12:01
@jfdenise
Copy link
Contributor Author

We will not follow this approach.

@jfdenise jfdenise closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfdenise @bstansberry