[WEJBHTTP-139] Final round of cleanup refactorings accross all modules #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reams unflushable
… ejb/Utils to common/Utils
…erviceConfig be the first parameter
…ut() instead of HeaderMap.add()
…ter code readability
… code readability
rachmatowicz
approved these changes
Jan 15, 2025
| @@ -42,6 +42,9 @@ final class Constants { | |||
| // context path | |||
| static final String TXN_CONTEXT = "/txn"; | |||
|
|
|||
| // params | |||
| static final String OPC_QUERY_PARAMETER = "opc"; | |||
There was a problem hiding this comment.
This string literal doesn't say much to me. A query parameter called "onePhase" would be more descriptive.
There was a problem hiding this comment.
We can change that in future versions of the protocol. We have to keep that name now for backward compatibility.
common/src/main/java/org/wildfly/httpclient/common/HeadersHelper.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/wildfly/httpclient/common/HeadersHelper.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/wildfly/httpclient/common/HeadersHelper.java
Outdated
Show resolved
Hide resolved
ejb/src/main/java/org/wildfly/httpclient/ejb/RequestBuilder.java
Outdated
Show resolved
Hide resolved
ejb/src/main/java/org/wildfly/httpclient/ejb/ClientHandlers.java
Outdated
Show resolved
Hide resolved
| @@ -73,4 +77,38 @@ public void write(final byte[] b, final int off, final int len) throws IOExcepti | |||
|
|
|||
| } | |||
|
|
|||
| private static final class UnflushableByteOutput implements ByteOutput { | |||
There was a problem hiding this comment.
It is the way this protocol was implemented. Output is always sent at once to prevent fragmentation on the wire.
I maintained it for backward compatibility. For future version of the protocol we could revisit it if its really necessary.
…legalArgumentException if HeadersHelper method parameter is null
… 'output' variable names for ObjectInput and ObjectOutput
…t and long as method parameters in HeadersHelper
…tead of txn for TransactionInfo parameter names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WEJBHTTP-139