Skip to content

Commit

Permalink
[WFCORE-4360] Addjust the comment regarding the tool to confirm dupli…
Browse files Browse the repository at this point in the history
…cate aliases will be replaced.
  • Loading branch information
darranl committed Feb 18, 2021
1 parent 9117dc5 commit 0088007
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions elytron/WFCORE-4360-CredentialStore_Expression_Resolution.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,18 @@ The `--import-secret-key` action will take the alias to store the key as an argu

* `--key` - The key to import encoded using Base64.

If the `--key` option is not specified the user will be prompted to enter the key interactively, this will avoid the key being seen in the current running processes and avoid the key being cached in the users command line history.
If the `--key` option is not specified the user will be prompted to enter the key interactively, this will avoid the key being seen in the current running
processes and avoid the key being cached in the users command line history.

NOTE: For `generate-secret-key` and `import-secret-key` if an entry already exists for that alias / algorithm combination the behaviour will be the same as the `add` action in relation to replacing the entry or reporting an error. (To be checked)
NOTE: For `generate-secret-key` and `import-secret-key` if an entry already exists for that alias / algorithm combination the entry in the credential store
will be replaced.

For this specific enhancement where an algorithm is required for the `SecretKey` we will use the hard coded value of `AES`, if later enhancement add support for further key types then it may be necessary for an optional `algorithm` argument / parameter to be added to each of the above commands / operations. Should an `algorithm` argument be added at a later point it would be optional and default to `AES` for backwards compatibility.
For this specific enhancement where an algorithm is required for the `SecretKey` we will use the hard coded value of `AES`, if later enhancement add support
for further key types then it may be necessary for an optional `algorithm` argument / parameter to be added to each of the above commands / operations. Should
an `algorithm` argument be added at a later point it would be optional and default to `AES` for backwards compatibility.

It is not feasible for all actions to have a short form so these new actions will have a long form only, within the tool we should try and restrict the use of the short form for parameters only.
It is not feasible for all actions to have a short form so these new actions will have a long form only, within the tool we should try and restrict the use of
the short form for parameters only.

==== Key manipulation - Management Operations

Expand Down

0 comments on commit 0088007

Please sign in to comment.