[WFLY-17766] undertow access log graceful termination #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darranl
requested changes
Mar 5, 2021
baranowb
changed the title
baranowb
changed the title
|
tmp update until process stuff will be sorted out. |
fl4via
reviewed
Apr 30, 2024
| - number of retries between NIO worker state polls | ||
| - interim period | ||
|
|
||
| NOTE: fix also slightly change how access log is being rotated. Previously it has been done on every write OP, which incured overhead. |
| Async close will wait till aloted time( with interim checks ) runs off to take over agressively write OPs or until NIO worker yield. As is, in fix number of interim checks and wait period is fixed(interim_period*number_of_retries). | ||
|
|
||
| RFE commits add changes to model and services in order to allow configuration of: | ||
| - number of retries between NIO worker state polls |
There was a problem hiding this comment.
do we really want to configure the number of retries, or just the maximum amount of delay here will be enough to server users? What I would like to know if there is a specific case where the final user might want to tweak the number of retries. Maybe we should come up with an algorithm that infers the number of retries based on the amount of delay that was configured.
There was a problem hiding this comment.
Granularity? GIves users better control.
baranowb
force-pushed
the
EAP7-1642
branch
2 times, most recently
from
4f9b81b to
7dbbc55
Compare
PrarthonaPaul
suggested changes
Jun 10, 2024
There was a problem hiding this comment.
Thanks @baranowb
I have added some comments.
Please feel free to let me know if you have any questions :)
|
Looks good to me! Thanks @baranowb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: https://issues.redhat.com/browse/EAP7-1642
RFE: https://issues.redhat.com/browse/WFLY-17766
https://issues.redhat.com/browse/WFLY-13933