-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-15016] Reactive Messaging and AMQ Streams support #414
Conversation
7e95083
to
c046ce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kabir - I had a quick look and dropped a couple of comments and questions.
Feel free to let me know what you think.
* mailto:{email}[{author}] | ||
|
||
=== QE Contacts | ||
TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can exceptionally add 3 contacts, BTW 😄 - Jan Stourac, Miroslav Novak and myself.
|
||
=== Non-Requirements | ||
|
||
TBD as we identify pain points during testing. I am not intimately familiar with Kafka/AMQ Streams. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any updates to resolve this section? Anything we should mention? BTW I see there's an open bug affecting the implementation, i.e. https://issues.redhat.com/browse/WFWIP-367
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is out of our hands really, as mentioned in https://issues.redhat.com/browse/WFWIP-367?focusedId=15583303&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15583303
This is covered by the linked <<Related Issues>>. | ||
|
||
== Release Note Content | ||
//// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This proposal is mostly about testing and documentation, so just asking: are there no community release notes that can be mentioned here? Maybe those of the related issues here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, connecting to AMQ Streams is essentially the same as we do to connect to Kafka. So there isn't anything special to work with AMQ Streams. Also the quickstart https://github.com/wildfly/quickstart/tree/main/microprofile-reactive-messaging-kafka covers how to set up AMQ Streams and connecting to it from WildFly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kabir - I dropped a couple more comments, so maybe we can have this proposal approved.
|
||
=== Related Issues | ||
|
||
* https://issues.redhat.com/browse/WFLY-14932[WFLY-14932 - Upgrade to MicroProfile Reactive Messaging 2.0] - This version introduces the new `@Channel` annotation, which makes it easier for users to get data into/from the Reactive Messaging Streams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong issue here, it should be the following one: https://issues.redhat.com/browse/WFLY-14798
* [x] QE | ||
|
||
=== Affected Projects or Components | ||
WildFly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given what we discussed recently about the involved components, shouldn't we add SmallRye RM too? Just asking, not sure it fits here.
https://issues.redhat.com/browse/WFLY-15016