-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-5691] proposal for bearer token timeout introspection #578
Open
rsearls
wants to merge
1
commit into
wildfly:main
Choose a base branch
from
rsearls:EAP7-1856-Bearer-Token-Authorization-Timeout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
125 changes: 125 additions & 0 deletions
125
elytron/WFCORE-5691-Bearer-Token-Authorization-Timeout.adoc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,125 @@ | ||
--- | ||
categories: | ||
- elytron | ||
--- | ||
= [Preview] Bearer token timeout configurability will be added to WildFly's Elytron subsystem. | ||
:author: Rebecca Searls | ||
:email: [email protected] | ||
:toc: left | ||
:icons: font | ||
:idprefix: | ||
:idseparator: | ||
|
||
== Overview | ||
|
||
Bearer Token Authorization is the process of authorizing HTTP requests based on | ||
the existence and validity of a bearer token. The token carries within it | ||
an expiration timestamp. The two parameters being added, connection-timeout | ||
and read-timeout are placed on the URL when obtaining the public key from the OAuth2 provider. | ||
|
||
|
||
== Issue Metadata | ||
|
||
=== Issue | ||
|
||
* https://issues.redhat.com/browse/WFCORE-5691[WFCORE-5691] | ||
|
||
=== Related Issues | ||
|
||
* https://issues.redhat.com/browse/EAP7-1856[EAP7-1856] | ||
* https://issues.redhat.com/browse/ELY-2189[ELY-2189] | ||
|
||
=== Stability Level | ||
// Choose the planned stability level for the proposed functionality | ||
* [ ] Experimental | ||
|
||
* [x] Preview | ||
|
||
* [ ] Community | ||
|
||
* [ ] default | ||
|
||
=== Dev Contacts | ||
|
||
* mailto:{email}[{author}] | ||
|
||
=== QE Contacts | ||
|
||
=== Testing By | ||
* [x] Engineering | ||
|
||
* [ ] QE | ||
|
||
=== Affected Projects or Components | ||
|
||
* WildFly-core | ||
* WildFly Elytron | ||
|
||
=== Other Interested Projects | ||
|
||
N/A | ||
|
||
=== Relevant Installation Types | ||
* [x] Traditional standalone server (unzipped or provisioned by Galleon) | ||
|
||
* [x] Managed domain | ||
|
||
* [x] OpenShift s2i | ||
|
||
* [x] Bootable jar | ||
|
||
== Requirements | ||
|
||
=== Hard Requirements | ||
|
||
* Two new attributes, `connection-timeout` and `read-timeout` will be | ||
added to the token-realm element in the Elytron subsystem of WildFly. | ||
|
||
Both parameters are datatype int. The value is in milliseonds. Only zero or positive integers are allowed. Zero means infinite time. WildFly uses a default | ||
value of 2000 milliseconds if this attribute is not declared. | ||
If the connection time and/or read time expires during | ||
public key retrieval a warning message is logged and null is returned as | ||
the public key to Elyton's process code. | ||
|
||
** connection-timeout: The value represents the length of time to wait when | ||
establishing a connection with the URL used to retrieve the public key. The attribute is optional. | ||
|
||
** read-timeout: The value represents the length of time to wait when | ||
downloading the public key from the URL. The attribute is optional. | ||
|
||
* wildfly-elytron_18_0.xsd will be updated to wildfly-elytron_preview_19_0.xsd with the added attributes | ||
|
||
=== Nice-to-Have Requirements | ||
|
||
N/A | ||
|
||
=== Non-Requirements | ||
|
||
N/A | ||
|
||
== Backwards Compatibility | ||
|
||
For backward compatibility the default value of 2000 milliseconds will be used for both attributes. This is a hard coded value used in Elytron since 2021. | ||
|
||
=== Default Configuration | ||
|
||
By default, neither, `connection-timeout` nor `read-timeout` will be | ||
declared. The default values will be used. | ||
|
||
== Test Plan | ||
|
||
* Elytron Tests: Integration test cases implemented for functionality. | ||
* WildFly Tests: Integration test cases implemented for functionality. | ||
* WildFly Testsuite: Test cases will be added to check for subsystem parsing. | ||
** Additional integration tests will be added to test the full functionality when `connection-timeout` and `read-timeout` are configured. | ||
* Tests will be added for subsystem configurations. | ||
* Tests may be added to ensure that server configuration fails when the stability level is not specified appropriately. | ||
|
||
== Community Documentation | ||
Documentation for `connection-timeout` and `read-timeout` will be added | ||
to https://github.com/wildfly/wildfly/blob/main/docs/src/main/asciidoc/_elytron/Bearer_Token_Authorization.adoc[Bearer Token Authorization] | ||
|
||
== Release Note Content | ||
|
||
It is now possible to set the timeout duration for introspecting a bearer token | ||
during Elytron's JWT format validation and OAuth2 validation process. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What public key?
What does placing these parameters on the URL do?
A user story would be good here.