-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Community] [WFCORE-6830] New attributes on the HTTP Management Interface to configure resource constraints. #595
Conversation
…igure resource constraints.
== Backwards Compatibility | ||
|
||
In considering backwards compatibility if an attribute is defined on the HTTP management interface AND the | ||
corresponding system property is set then the system property should take precedence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this happens we should log a WARN that the system property will be removed. People should move promptly off of system property based configuration once proper attributes are available.
And then remove it in, say, WF 36, assuming this lands in WF 34.
Probably using the same logger category that we use when warning about use of deprecated management API would be good. It's an analogous situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I can add that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated to add the logging:
The other deprecation messages all appear to use INFO so I have done the same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
The management console page for the management interface is at http://localhost:9900/console/index.html#standalone-server Runtime → Select server → View → HTTP Management Interface The form for the management interface contains all simple configuration attributes. The new attributes should show up automatically. |
… be output. Also include an example of the output message.
I have added an "Admin Clients" section to the analysis and confirm that the new attributes are automatically handled by both admin clients: |
[source] | ||
---- | ||
14:58:13,878 INFO [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0515: The system | ||
property 'org.wildfly.management.backlog' is deprecated and may be removed in a future version, attribute 'backlog' on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/version, attribute/version. The attribute/g
This is more a comment for the impl PR, so don't feel the need to change this if you wouldn't otherwise.
a stability level that supports these new attributes the admin console will automatically support them - in other cases they | ||
will not be present in the view. | ||
|
||
No follow up tasks are required for either admin client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OT: We should make this easily cut-and-pasted content; perhaps in a more fleshed out https://github.com/wildfly/wildfly-proposals/blob/main/FEATURE_PROCESS.adoc
No description provided.