Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Community] [WFCORE-6830] New attributes on the HTTP Management Interface to configure resource constraints. #595

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

darranl
Copy link
Contributor

@darranl darranl commented Sep 6, 2024

No description provided.

== Backwards Compatibility

In considering backwards compatibility if an attribute is defined on the HTTP management interface AND the
corresponding system property is set then the system property should take precedence.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this happens we should log a WARN that the system property will be removed. People should move promptly off of system property based configuration once proper attributes are available.

And then remove it in, say, WF 36, assuming this lands in WF 34.

Probably using the same logger category that we use when warning about use of deprecated management API would be good. It's an analogous situation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I can add that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated to add the logging:

https://github.com/wildfly/wildfly-proposals/pull/595/files#diff-c4fba9f719d2a6d63183999eb1869081774e7d44fb5d70004133b12de65c8dd6R176

The other deprecation messages all appear to use INFO so I have done the same here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@hpehl
Copy link
Contributor

hpehl commented Sep 9, 2024

The management console page for the management interface is at http://localhost:9900/console/index.html#standalone-server

Runtime → Select server → View → HTTP Management Interface

CleanShot 2024-09-09 at 13 02 39

The form for the management interface contains all simple configuration attributes. The new attributes should show up automatically.

@darranl
Copy link
Contributor Author

darranl commented Sep 15, 2024

I have added an "Admin Clients" section to the analysis and confirm that the new attributes are automatically handled by both admin clients:
https://github.com/wildfly/wildfly-proposals/pull/595/files#diff-c4fba9f719d2a6d63183999eb1869081774e7d44fb5d70004133b12de65c8dd6R198

[source]
----
14:58:13,878 INFO [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0515: The system
property 'org.wildfly.management.backlog' is deprecated and may be removed in a future version, attribute 'backlog' on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/version, attribute/version. The attribute/g

This is more a comment for the impl PR, so don't feel the need to change this if you wouldn't otherwise.

a stability level that supports these new attributes the admin console will automatically support them - in other cases they
will not be present in the view.

No follow up tasks are required for either admin client.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OT: We should make this easily cut-and-pasted content; perhaps in a more fleshed out https://github.com/wildfly/wildfly-proposals/blob/main/FEATURE_PROCESS.adoc

@bstansberry bstansberry merged commit f5fde7e into wildfly:main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants