Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin client requirements to the process #600

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

darranl
Copy link
Contributor

@darranl darranl commented Sep 15, 2024

The updates I am proposing here relate to how in general the admin clients should be considered when new features are added to the application server.

The admin clients are maintained by smaller teams within the overall WildFly team, for this reason it is not going to scale if every feature requires complete admin client integration at every stability level so the general premise behind this proposal is that features can be added at Experimental or Preview level with a reduced set of admin client requirements, the admin clients can then continue to evolve to add these features and then the underlying feature can be promoted to Community / Default.

Note: This is not so much about features being added directly to the admin clients at the stability levels as in that case the admin client developer is already in control of compatibility etc...

design-doc-template.adoc Outdated Show resolved Hide resolved
design-doc-template.adoc Outdated Show resolved Hide resolved
design-doc-template.adoc Outdated Show resolved Hide resolved
design-doc-template.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @darranl. I'll leave merging this to you as you know what other feedback you want.

@darranl
Copy link
Contributor Author

darranl commented Sep 17, 2024

@hpehl / @jfdenise Can you both please have a look at this and check it makes sense for you?

This is more about how the admin clients will be updated based on other changes to the app server rather than features added directly to the admin clients.

| *Admin Clients*
(HAL / JBoss CLI)

| Management model changes must be compatible with the lowe level model
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowe? you mean lowest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I have fixed this.

Copy link
Contributor

@hpehl hpehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @darranl

@darranl
Copy link
Contributor Author

darranl commented Sep 18, 2024

I just sent a message to the dev list, I think will give it one more day then merge.

Being merged does not set it in stone so we can still evolve as feedback comes in / we try and work with these contraints.

@bstansberry bstansberry merged commit c6d3807 into wildfly:main Sep 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants