add testcase for custom regex.

refs: #42
willdurand · Nov 28, 2017 · 7c64d7d · 7c64d7d
1 parent fc1039c
commit 7c64d7d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/EmailReplyParser/Parser/EmailParser.php b/src/EmailReplyParser/Parser/EmailParser.php
@@ -145,6 +145,7 @@ public function setQuoteHeadersRegex(array $quoteHeadersRegex)
 
     /**
      * @return string
+     * @since 2.7.0
      */
     public function getSignatureRegex()
     {
@@ -155,6 +156,7 @@ public function getSignatureRegex()
      * @param string $signatureRegex
      *
      * @return EmailParser
+     * @since 2.7.0
      */
     public function setSignatureRegex($signatureRegex)
     {

diff --git a/tests/EmailReplyParser/Tests/Parser/EmailParserTest.php b/tests/EmailReplyParser/Tests/Parser/EmailParserTest.php
@@ -410,6 +410,24 @@ public function testEmailWithFairAmountOfContent()
         $this->assertRegexp('/^On Thursday/', (string) $fragments[0]);
     }
 
+    /**
+     * override regexp, not to match too greedy signature.
+     *
+     * See: https://github.com/willdurand/EmailReplyParser/pull/42
+     */
+    public function testCustomSignatureRegex()
+    {
+        $signatureRegex = '/(?:^\s*--|^\s*__|^-- $)|(?:^Sent from my (?:\s*\w+){1,3})$/s';
+        $this->parser->setSignatureRegex($signatureRegex);
+        $email = $this->parser->parse($this->getFixtures('email_ls-l.txt'));
+        $fragments = $email->getFragments();
+
+        // this should match two blocks, body and a signature
+        $this->assertCount(2, $fragments);
+        $this->assertFalse($fragments[0]->isSignature());
+        $this->assertTrue($fragments[1]->isSignature());
+    }
+
     /**
      * @dataProvider getDateFormats
      */