I think my build conditionals are wrong

william-dawson · Nov 15, 2023 · d2243e4 · d2243e4
1 parent 91200d5
commit d2243e4
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/UnitTests/run_cmake.sh b/UnitTests/run_cmake.sh
@@ -10,15 +10,14 @@ if [[ "$TESTOS" == "OSX" ]]; then
   cmake -G Ninja .. -DCMAKE_TOOLCHAIN_FILE=../Targets/Mac-python3.cmake \
     -DCMAKE_BUILD_TYPE=Release ;
 else
-  if  [ ! -z ${NOIALLGATHER+x} ]; then
-    cmake -G Ninja .. \
-          -DCMAKE_BUILD_TYPE=Debug -DNOIALLGATHER=YES;
-  elif [ ! -z ${DEBUG+x} ]; then
+  if [[ "${NOIALLGATHER:-0}" -eq 1 ]]; then
+    cmake -G Ninja .. -DCMAKE_BUILD_TYPE=Debug -DNOIALLGATHER=YES;
+  elif [[ "${DEBUG:-0}" -eq 1 ]]; then
     cmake -G Ninja .. -DCMAKE_TOOLCHAIN_FILE=../Targets/Linux.cmake \
-          -DCMAKE_BUILD_TYPE=Debug ;
+      -DCMAKE_BUILD_TYPE=Debug;
   else
     cmake -G Ninja .. -DCMAKE_TOOLCHAIN_FILE=../Targets/Linux.cmake \
-          -DCMAKE_BUILD_TYPE=Release ;
+      -DCMAKE_BUILD_TYPE=Release;
   fi
 fi