Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Update docker-compose.yml images and nginx config mount #11

Merged

Conversation

vaugenwake
Copy link
Contributor

PR to update the docker-compose.yml template.

Changes:

  • Update composer build: to be image:
  • Update nginx config mount path to: /docker/nginx/default.conf as /etc/nginx/conf.d/default.conf is a file not a directory
  • Update PHP image to be FPM

Copy link
Owner

@willitscale willitscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, just occurred to me I never tested the docker compose

@willitscale willitscale merged commit 514145e into willitscale:main Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants