Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make "compile" option available to use a custom compile function #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

willybrauner
Copy link
Owner

import { compile } from "path-to-regexp"
// pass a custom compile function to the router options
const router = new LowRouter(routes, { compile })

Copy link

codesandbox bot commented Oct 21, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 91ee31b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@willybrauner
Copy link
Owner Author

willybrauner commented Oct 21, 2024

size-limit report 📦

Path Size
@wbe/low-router 1.86 KB (+1.22% 🔺)
@wbe/low-router-preact 11.16 KB (+0.16% 🔺)

Copy link

codesandbox-ci bot commented Oct 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 91ee31b:

Sandbox Source
example-low-router-basic Configuration
example-low-router-basic-resolve-sync Configuration
example-low-router-compose Configuration
example-custom-path-to-regexp Configuration
example-react-nested-routes Configuration
example-preact-ssr Configuration
example-preact-ssr-static-props Configuration

@willybrauner willybrauner force-pushed the compile-path-as-option branch from 3e53492 to 499d083 Compare October 21, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant