Update windpowerlib to work for newer python versions and add automatic testing #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicated wind speed entries lead to errors
I couldn't reproduce the full load hours previously set (1956.164053) even with older versions of python (checked down to 3.8) and pandas (checked down to 1.3.5), so I assume, that the value was incorrect. It was possibly not checked, as the example tests are not in the tests directory but the example directory.
…k is run using pytest_notebook
…d on the other np.int64
…64 and on linux np.int32
…are run on github
…ors" This reverts commit 07649a9.
…o 13] Permission denied
uvchik
reviewed
Feb 8, 2024
windpowerlib/data.py
Outdated
| if len(broken_turbine_data) < 0.2 * len(turbine_data): | ||
| logging.warning( | ||
| f"The turbine library data contains faulty {curve_type}s. The " | ||
| f"{curve_type} data can therefore not be loaded for the following " |
There was a problem hiding this comment.
I am not sure, but I think that one broken data set can make the whole file unusable. Maybe we should add a hint that in that case it is possible to use the function restore_default_turbine_data()
There was a problem hiding this comment.
Actually I added these checks so that one broken data set could not make the newly downloaded data unusable, as happened in the last weeks due to bugs in the oedb turbine library data. I moved the checks to a separate function now to be able to test it independent of the oedb data and added tests to show that it is working correctly.
…to allow testing independent from oedb data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: