feature: call _setMetadata in createDao #374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjHare
reviewed
Sep 22, 2022
| @@ -130,7 +131,7 @@ describe('Staking Pool Mediator contract', () => { | |||
| const expectedDaoId = previousHighestDaoId.add(1).toBigInt() | |||
There was a problem hiding this comment.
issue: You need t least one new test case: when METADATA is undefined.
Depends on what the expected behaviour is for metadata, whether it's mandatory (where you'll need more) or optional
There was a problem hiding this comment.
Ok i've added one - set as empty string. Is this what you mean or you are talking about calling createDao() with an empty string?
There was a problem hiding this comment.
Yes, invoking createDao() with an empty string.
|
replaced by #376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose for this PR
as per #359