Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WINDUPRULE-1042] Implement JMS to Quarkus rules #1043

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

jmle
Copy link
Contributor

@jmle jmle commented Dec 5, 2023

@PhilipCattanach
Copy link
Contributor

@jmle Thank you for the PR.
Overall a great addition but I do have a few comments.

1). There are duplicate rule ids -00030

2). Some of the rules only contain a link to the https://quarkus.io/guides/ page.
Can we not be more specific than that?

3). Why do the rules that reference javax.ejb.ActivitionConfigProperty, javax.jms.Queue and javax.jms.Topic not also
check for the jakarta. equivalents?

jmle added 3 commits December 12, 2023 07:40
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
@PhilipCattanach
Copy link
Contributor

Thanks @jmle - I'll review this PR later today.

@PhilipCattanach PhilipCattanach added auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch labels Dec 12, 2023
@PhilipCattanach
Copy link
Contributor

A couple of observations, but nothing to prevent the merge
1). I think there is no need for the apostrophe in the hint title for rule #30 and #40
2). I would have like to have data to trigger the jakarta based when criteria. All of the rules tests are driven by the javax test data.

@PhilipCattanach PhilipCattanach merged commit 40d3c19 into windup:master Dec 12, 2023
github-actions bot pushed a commit that referenced this pull request Dec 12, 2023
* [WINDUPRULE-1042] Implement JMS to Quarkus rules

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>

* [WINDUPRULE-1042] Refactor names

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>

* [WINDUPRULE-1042] Improve rules, fix test

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>

* [WINDUPRULE-1042] Fix tests

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>

---------

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
(cherry picked from commit 40d3c19)
Copy link

💚 All backports created successfully

Status Branch Result
releases/6.3.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mrizzi pushed a commit that referenced this pull request Dec 13, 2023
* [WINDUPRULE-1042] Implement JMS to Quarkus rules

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>

* [WINDUPRULE-1042] Refactor names

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>

* [WINDUPRULE-1042] Improve rules, fix test

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>

* [WINDUPRULE-1042] Fix tests

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>

---------

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
(cherry picked from commit 40d3c19)

Co-authored-by: Juan Manuel Leflet Estrada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants