-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Guix support #115
Merged
Merged
Improve Guix support #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emixa-d
reviewed
Nov 17, 2024
emixa-d
reviewed
Nov 17, 2024
emixa-d
reviewed
Nov 17, 2024
emixa-d
reviewed
Nov 17, 2024
emixa-d
reviewed
Nov 17, 2024
emixa-d
requested changes
Nov 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The security thing is particularly important.
This follows the guidelines in <https://guix.gnu.org/cookbook/en/html_node/Software-Development.html>. * .guix/modules/fibers-package.scm: New file, based on… * guix.scm: … this. Turn into a symlink to the above. * Makefile.am (EXTRA_DIST): Add both files.
This is clearer and less ambiguous: if the person has additional channels providing same-named packages, it will still refer to the canonical packages under (gnu packages …). * .guix/modules/fibers-package.scm (S): Remove. (guile-fibers)[native-inputs, inputs]: Directly refer to the right (gnu packages …) variables. [synopsis]: Remove outdated sentence.
* .guix/modules/fibers-package.scm (guile2.2-fibers) (guile-fibers/libevent): New variables.
* .guix/modules/fibers-package.scm (guile-fibers)[native-inputs]: Add Guile.
* .guix/manifest.scm: New file. * Makefile.am (EXTRA_DIST): Add it.
civodul
force-pushed
the
improve-guix-support
branch
from
November 23, 2024 10:45
d18e054
to
9dc3c95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches improves Guix support to make it easier to test a variety of configurations.
With the last patch, runnin:
... will perform several native builds (x86_64-linux, i686-linux, Guile 3.0 and 2.2, with and without libevent) and cross-compilation builds (currently failing; see #111).