Add a global setting 'misMatchPercentage' to define a KO test beyond thi... #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this percentage (default is 0%)
|
Hi thanks for the request. from my perspective, Viff is a tool to help the guys find the difference quickly, if you set KO line for test, you also don't know if the differences is important or not. I will hold this request for a while, I need to validate that does people want this feature. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a global setting 'misMatchPercentage' to define a KO test beyond this percentage (default is 0%).
A comparison of images may sometimes be slightly different (an offset of 1 pixel). In our case we want to identify a significant difference between two images and therefore put a test KO when the percentage difference is beyond a given threshold.