Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 5.0.0 #389

Merged
merged 10 commits into from
Feb 9, 2024
Merged

Prepare 5.0.0 #389

merged 10 commits into from
Feb 9, 2024

Conversation

Apollon77
Copy link
Collaborator

@Apollon77 Apollon77 commented Feb 7, 2024 •
edited
Loading

This PR includes:

closes #366

@Apollon77
Prevent crash in bad timing cases
f0f94d6 
Resolves error cases like

```
ENOENT: no such file or directory, unlink '/opt/iobroker/log/iobroker.2023-01-04.log'
Error: ENOENT: no such file or directory, unlink '/opt/iobroker/log/iobroker.2023-01-04.log'
    at Object.unlinkSync (node:fs:1767:3)
    at WriteStream.<anonymous> (/opt/iobroker/node_modules/winston-daily-rotate-file/daily-rotate-file.js:140:28)
    at WriteStream.emit (node:events:525:35)
    at WriteStream.emit (node:domain:489:12)
    at finish (node:internal/streams/writable:756:10)
    at finishMaybe (node:internal/streams/writable:741:9)
    at afterWrite (node:internal/streams/writable:506:3)
    at onwrite (node:internal/streams/writable:479:7)
    at node:internal/fs/streams:416:5
    at FSReqCallback.wrapper [as oncomplete] (node:fs:816:5)

```
@Apollon77
if we ignore the error we also do not need the exists check
bc6e7b6
@Apollon77
Update code
6382c91
@Apollon77
Update tests
72e6fbc
@Apollon77
Update dependencies
1708522
@Apollon77
Update README
9b3f483
@Apollon77
sync package-lock
29deea3
@Apollon77
fix license year information
ef95cbe
@Apollon77
Release script and GHA update
e642386
foxriver76
foxriver76 requested changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@foxriver76 foxriver76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.

However, we should clarify the README part about the error handler or re-throw to match the behavior.

Not sure about the port to ES6 part or did you mean the arrow functions?

daily-rotate-file.js Show resolved Hide resolved
daily-rotate-file.js Show resolved Hide resolved
@Apollon77
Copy link
Collaborator Author

Not sure about the port to ES6 part or did you mean the arrow functions?

As written above I "Only" changed to lat/const and arrow functions ... ok not really es6 class because I'm not sure if this is compatible with the base "prototype" (aka winston-transport). This is an open topic for later

@Apollon77 Apollon77 mentioned this pull request Feb 7, 2024
Closed
@Apollon77
Copy link
Collaborator Author

@mattberther For the relöeases to work it would need a Github Actions secreat with name NPM_TOKEN with an npmjs automation token in there ... you could do with yours or we find a way how I can send you one

@DABH
Copy link

DABH commented Feb 9, 2024

@Apollon77 As mentioned in #388 , you should have admin access for the repo now to add your own secrets as you see fit...

DABH
DABH approved these changes Feb 9, 2024
View reviewed changes
Copy link

@DABH DABH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give my stamp with the caveat that I don't use this transport in my apps, but the changes here generally look safe to me.

@Apollon77
Copy link
Collaborator Author

Thank you, then I will prepare the secret and merge here and then release a 5.0 ... then we are also safe and we can update ioBroker to proof it still working

@Apollon77 Apollon77 merged commit ae6ba2d into winstonjs:master Feb 9, 2024
5 checks passed
@Apollon77 Apollon77 deleted the update branch February 9, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foxriver76 foxriver76 foxriver76 approved these changes

@DABH DABH DABH approved these changes

@mattberther mattberther Awaiting requested review from mattberther

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apollon77 @DABH @foxriver76