fix write call in unit tests #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you are able to get readable-stream updated in winston-transport, winston, and logform (is it used there? maybe not), that would be incredible 😍 Thank you so much for the contribution! Will try to review any PRs you open |
DABH
approved these changes
Sep 27, 2024
|
@DABH Thanks for merging this and releasing a new version. Working on updating Winston with the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried updating the package
readable-streamto4.5.2and noticed that some unit tests are failing. That is becausetransport.writeis called with additional parameters fromforEach.forEachpasses three parameters to its callback (MDN):element,indexandarray.writeshould only receiveelement, but previously, it also receivedindexasencandarrayascallback.This PR changes this, so that only
elementis provided.I would like to see readable-stream updated and can provide another PR for that. I think dependabot already tried that and failed, maybe because the tests failed.